-
Notifications
You must be signed in to change notification settings - Fork 209
[Caching] Support pluginCAS in swiftDriver #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cachemeifyoucan
merged 1 commit into
swiftlang:main
from
cachemeifyoucan:eng/PR-swift-driver-plugin-cas-support
Sep 7, 2023
Merged
[Caching] Support pluginCAS in swiftDriver #1422
cachemeifyoucan
merged 1 commit into
swiftlang:main
from
cachemeifyoucan:eng/PR-swift-driver-plugin-cas-support
Sep 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on swiftlang/swift#67942 Split out from old #1415 for the pluginCAS part. |
643448a
to
b753c34
Compare
We should update |
artemcm
reviewed
Aug 22, 2023
artemcm
approved these changes
Aug 22, 2023
35d2c80
to
603745b
Compare
benlangmuir
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add tests for this change?
3c22c00
to
93eb8cc
Compare
@swift-ci please test |
benlangmuir
approved these changes
Aug 28, 2023
Add support for pluginCAS by adopting the new SwiftScan CAS creation APIs. The old CAS creation API is deprecated, and will be removed once all users are updated.
93eb8cc
to
bb0a153
Compare
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for pluginCAS by adopting the new SwiftScan CAS creation APIs. The old CAS creation API is deprecated, and will be removed once all users are updated.