Skip to content

[Incremental Builds]skip startingPoint of changed .swiftmodule #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Incremental Builds]skip startingPoint of changed .swiftmodule #1994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraphParts/Tracer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,22 @@ extension ModuleDependencyGraph.Tracer {

private mutating func collectPreviouslyUntracedDependents() {
for n in startingPoints {
if (n.key.aspect == .interface) {
if case .sourceFileProvide(name: _) = n.key.designator {
if case let .known(source) = n.definitionLocation {
if source.typedFile.type == .swiftModule {
// If a change in the fingerprint of an interface causes a change in the swiftmodule,
// but other swiftmodules that depend on this swiftmodule do not depend on this interface,
// then those other swiftmodules should not be recompiled.
//
// This means that recompilation is only triggered when the fingerprint of a dependent interface changes.
graph.info.reporter?.report("skipped startingPoint key: \(n.key.description(in: graph)) definitionLocation: \(n.definitionLocation)")
continue
}
}
}
}
graph.info.reporter?.report("startingPoint key: \(n.key.description(in: graph)) definitionLocation: \(n.definitionLocation)")
collectNextPreviouslyUntracedDependent(of: n)
}
}
Expand Down