Efficient Dictionary.mapValues with key context
#3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayloraswift
force-pushed
the
dictionary-mapvalues-with-keys
branch
from
b967289 to
a90d3e5
Compare
7 tasks
rjmccall
added
LSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Efficient
Dictionary.mapValueswith key contextI propose adding an overload to
Dictionary.mapValues(andOrderedDictionary.mapValues) that passes theKeyto the transformation closure.This enables us to transform dictionary values with their associated key context without incurring the performance cost of rehashing (or in the case of
reduce, reallocating) the dictionary storage, which is currently unavoidable when usinginit(uniqueKeysWithValues:)orreduce(into:).