Box #3067
Open
Box #3067
+350
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I barely skimmed through the proposal and I'm already pumped for it as it's 1 more utility that actually leverages non-copyable types. What's the relation of this It looks like these are the same types, but I didn't see a mention of |
xwu
reviewed
Jan 7, 2026
| `take` comes from `Optional.take()` and `move` from `UnsafeMutablePointer.move()`. | ||
| Both of those methods don't actually consume the parent instance they are called | ||
| on however unlike `consume`. Calling `consume` ends the lifetime of `Box` and it | ||
| is immediately deallocated after returning the instance stored within. |
Contributor
There was a problem hiding this comment.
(There is also Result.get(), which is consuming, and for which as I recall the core team had previously stated get would become a term-of-art.)
Contributor
Author
|
@MahdiBM it's the same type as found in swift-collections |
Reword some things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing
Boxto the standard library which is a safe smart pointer that uniquely owns some value.