Keep attributed getters intact in UseSingleLinePropertyGetter #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
requested review from
allevato,
bnbarham,
hamishknight and
rintaro
as code owners
allevato
approved these changes
Dec 1, 2025
Member
allevato
left a comment
allevato
left a comment
There was a problem hiding this comment.
Yeah, this is the right choice. Having any attributes on the accessor itself is a statement of intent, so we should respect that. (Most attributes that go on accessors are specific to that accessor function anyway, just like how async throws goes there.)
Contributor
|
Thanks @TTOzzi! |
Member
|
Thanks for the quick fix @TTOzzi 🙏🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1102
Fix
UseSingleLinePropertyGetterso that explicit getters are left untouched when they carry attributes (e.g.@_lifetime).Since it’s not clear how to reliably distinguish between attributes that can appear at the property level and those that are accessor-only, it seems safer to avoid collapsing getters whenever attributes are present 🤔