Skip to content

[CI] Add soundness check #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 30, 2024
Merged

[CI] Add soundness check #824

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c4ae8e
[CI] Add soundness check
shahmishal Sep 30, 2024
62cf771
Update pull_request.yml
shahmishal Sep 30, 2024
410e7e6
Update pull_request.yml format
shahmishal Sep 30, 2024
e0365bd
Add ignore-unacceptable-language comment to PrettyPrinter.md
shahmishal Sep 30, 2024
9957ea0
Add ignore-unacceptable-language to TokenStreamCreator.swift
shahmishal Sep 30, 2024
9de07bb
For now disable the format check until the repo is updated
shahmishal Sep 30, 2024
58e2bca
Remove default inputs from the workflow file
shahmishal Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,15 @@ jobs:
tests:
name: Test
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
soundness:
name: Soundness
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
with:
api_breakage_check_enabled: true
broken_symlink_check_enabled: true
docs_check_enabled: true
format_check_enabled: true
license_header_check_enabled: false
license_header_check_project_name: "Swift.org"
shell_check_enabled: true
unacceptable_language_check_enabled: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these are enabled in the workflow by default, right? So we could omit all the : true lines, right?

2 changes: 1 addition & 1 deletion Documentation/PrettyPrinter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,6 @@ sense to place this label on the containing group.

Oppen's algorithm prints the indentation whitespace when `break` tokens are
encountered. If we have extra blank lines in between source code, this can
result in hanging or trailing whitespace. Waiting to print the indentation
result in hanging or trailing whitespace. Waiting to print the indentation <!--# ignore-unacceptable-language -->
whitespace until encountering a `syntax`, `comment, or `verbatim` tokens
prevents this.
2 changes: 1 addition & 1 deletion Sources/SwiftFormat/PrettyPrint/TokenStreamCreator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor {
/// - rightDelimiter: The right parenthesis or bracket surrounding the arguments, if any.
/// - forcesBreakBeforeRightDelimiter: True if a line break should be forced before the right
/// right delimiter if a line break occurred after the left delimiter, or false if the right
/// delimiter is allowed to hang on the same line as the final argument.
/// delimiter is allowed to hang on the same line as the final argument. # ignore-unacceptable-language
private func arrangeFunctionCallArgumentList(
_ arguments: LabeledExprListSyntax,
leftDelimiter: TokenSyntax?,
Expand Down
Loading