Skip to content

[Perf][WhitespaceLinter] Use hand crafted "is whitespace" function #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[Perf][WhitespaceLinter] Use hand crafted "is whitespace" function #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Sources/SwiftFormat/PrettyPrint/WhitespaceLinter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,16 @@ public class WhitespaceLinter {
startingAt offset: Int,
in data: [UTF8.CodeUnit]
) -> ArraySlice<UTF8.CodeUnit> {
func isWhitespace(_ char: UTF8.CodeUnit) -> Bool {
switch char {
case UInt8(ascii: " "), UInt8(ascii: "\n"), UInt8(ascii: "\t"), UInt8(ascii: "\r"), /*VT*/ 0x0B, /*FF*/ 0x0C:
return true
default:
return false
}
}
guard
let whitespaceEnd =
data[offset...].firstIndex(where: { !UnicodeScalar($0).properties.isWhitespace })
let whitespaceEnd = data[offset...].firstIndex(where: { !isWhitespace($0) })
else {
return data[offset..<data.endIndex]
}
Expand Down
Loading