[6.1] Run Windows tests inside a Docker container #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Mar 5, 2025
ahoppen
commented
- Explanation: Looks like GitHub updated Visual Studio on their Windows runners and the new SDK causes compilation issues. Run in a Docker container so we fully control the version of Visual Studio installed.
- Scope: GitHub Actions used for PR testing and tagging swift-format semantic versioning releases
- Issue: n/a
- Original PR: Run Windows tests inside a Docker container #951 / Run the publish release workflow inside a Docker container on Windows #952
- Risk: None, only affects CI, which is currently broken
- Testing: Checked that CI passes with this change on main
- Reviewer: @bnbarham
Looks like GitHub updated Visual Studio on their Windows runners and the new SDK causes compilation issues. Run in a Docker container so we fully control the version of Visual Studio installed.
bnbarham
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.