Skip to content

Conversation

iCharlesHu
Copy link
Contributor

ICUExport is a command utility that is used to upgrade swift-foundation-icu's ICU version to match the version released by apple-oss-distribution. The goal for these upgrades is to ensure SwiftFoundation uses the same ICU version on all platforms.

@iCharlesHu iCharlesHu requested a review from itingliu October 14, 2025 20:03
@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

@itingliu
Copy link

I can't tell what's wrong with the format check. Are you able to tell?

…for the swift-foundation-icu, based on ICU releases from apple-oss-distribution
@iCharlesHu
Copy link
Contributor Author

@itingliu I think I used the wrong header in one of the files. Should be fixed now.

@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

@itingliu
Copy link

itingliu commented Oct 17, 2025

The format check is still failing and I'm still not able to find any useful logs besides Error: Process completed with exit code 1.

It looks like it's running this script for format-check:
https://github.com/swiftlang/github-workflows/blob/main/.github/workflows/scripts/check-swift-format.sh

so I tried running this script manually. I'm seeing all of the diffs it outputs to replace 4-whitespace indentation into 2-whitespace ones, but I'm not hitting any exit code 1. I'm not sure if I misunderstood how the script is supposed to test and work though. Do you know if this soundness check is supposed to fail if we don't use the predefined 2-space format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants