Skip to content

Move off of RegexBuilder for URL.Template #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025
Merged

Move off of RegexBuilder for URL.Template #1273

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4731a51
Revert RegexBuilder workaround
danieleggert Apr 25, 2025
e885e96
Cleanup private
danieleggert Apr 25, 2025
203c480
Move off of RegexBuilder
danieleggert Apr 25, 2025
e72ec21
Merge branch 'main' into uri-templating-regex
danieleggert May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/FoundationEssentials/URL/URLTemplate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ extension URL {

// MARK: - Parse

@available(FoundationPreview 6.2, *)
extension URL.Template {
/// Creates a new template from its text form.
///
Expand Down Expand Up @@ -176,6 +177,7 @@ extension URL.Template: CustomStringConvertible {
}
}

@available(FoundationPreview 6.2, *)
Copy link
Contributor

@jrflat jrflat May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this annotation is needed since URL.Template.Element is an internal type, but otherwise LGTM!

extension URL.Template.Element: CustomStringConvertible {
var description: String {
switch self {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.