[Data] Fix build issue with Static SDK for Linux.#1293
Merged
parkera merged 1 commit intoswiftlang:mainfrom May 16, 2025
Merged
[Data] Fix build issue with Static SDK for Linux.#1293parkera merged 1 commit intoswiftlang:mainfrom
parkera merged 1 commit intoswiftlang:mainfrom
Conversation
al45tair
force-pushed
the
fix-static-sdk-build
branch
from
7dc4434 to
aa17422
Compare
Contributor
Author
|
@swift-ci Please test |
parkera
reviewed
May 15, 2025
Musl's definition of `S_IFMT` gets imported by the Swift importer, which means Swift can see `S_IFMT` as a `CInt` and also `S_IFMT` from the Swift overlay as a `mode_t`. The upshot is that attempting to convert it to `mode_t` produces an ambiguity error, as Swift doesn't know which definition to use. rdar://147201087
al45tair
force-pushed
the
fix-static-sdk-build
branch
from
aa17422 to
ea9df5d
Compare
Contributor
Author
|
@swift-ci Please test |
parkera
approved these changes
May 16, 2025
Contributor
|
Perfect, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Musl's definition of
S_IFMTgets imported by the Swift importer, which means Swift can seeS_IFMTas aCIntand alsoS_IFMTfrom the Swift overlay as amode_t. The upshot is that attempting to convert it tomode_tproduces an ambiguity error, as Swift doesn't know which definition to use.