fix recurrence nanosecond handling for nanosecond values > 0.5 #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@swift-ci please test |
parkera
approved these changes
May 29, 2025
stephentyrone
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #1284: we missed the fact that
remainder(dividingBy:)can produce negative values if the input's fractional part is greater than 0.5. (eg:1.9.remainder(dividingBy: 1)is -0.1).Since the dates produced by
Calendar.DatesByRecurring.Iteratorall have their nanosecond component set to 0 (rather than being rounded to the nearest whole number), we need to usetruncatingRemainder(dividingBy:)instead.I also changed it to operate on
timeIntervalSinceReferenceDateinstead oftimeIntervalSince1970, since that saves us on having to perform thetimeIntervalSince1970computation every time.