Skip to content

Reenable AttributedString index tracking swift testing tests #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Reenable AttributedString index tracking swift testing tests #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f8e8c9
Revert "Revert "Add tests for AttributedString Index Tracking precond…
jmschonfeld Jun 6, 2025
dbe20fc
Disable exit tests on Ubuntu 20.04 for now
jmschonfeld Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,20 @@ let wasiLibcCSettings: [CSetting] = [
.define("_WASI_EMULATED_MMAN", .when(platforms: [.wasi])),
]

var testOnlySwiftSettings: [SwiftSetting] = [
// The latest Windows toolchain does not yet have exit tests in swift-testing
.define("FOUNDATION_EXIT_TESTS", .when(platforms: [.macOS, .linux, .openbsd]))
]

#if os(Linux)
import FoundationEssentials

if ProcessInfo.processInfo.operatingSystemVersionString.hasPrefix("Ubuntu 20.") {
// Exit tests currently hang indefinitely on Ubuntu 20.
testOnlySwiftSettings.removeFirst()
}
#endif

let package = Package(
name: "swift-foundation",
platforms: [.macOS("15"), .iOS("18"), .tvOS("18"), .watchOS("11")],
Expand Down Expand Up @@ -171,7 +185,7 @@ let package = Package(
"LifetimeDependenceMutableAccessors",
.when(platforms: [.macOS, .iOS, .watchOS, .tvOS, .linux])
),
] + availabilityMacros + featureSettings
] + availabilityMacros + featureSettings + testOnlySwiftSettings
),

// FoundationInternationalization
Expand Down Expand Up @@ -204,7 +218,7 @@ let package = Package(
"TestSupport",
"FoundationInternationalization",
],
swiftSettings: availabilityMacros + featureSettings
swiftSettings: availabilityMacros + featureSettings + testOnlySwiftSettings
),

// FoundationMacros
Expand Down Expand Up @@ -236,7 +250,7 @@ package.targets.append(contentsOf: [
"FoundationMacros",
"TestSupport"
],
swiftSettings: availabilityMacros + featureSettings
swiftSettings: availabilityMacros + featureSettings + testOnlySwiftSettings
)
])
#endif
Loading
Loading