Skip to content

[Implementation] ProgressManager Implementation #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 85 commits into from
Closed

[Implementation] ProgressManager Implementation #1362

wants to merge 85 commits into from

Conversation

@chloe-yeo
Copy link
Contributor

@chloe-yeo chloe-yeo commented Jun 16, 2025

No description provided.

chloe-yeo added 30 commits June 16, 2025 16:07
@chloe-yeo
move files to FoundationPreview
ae0d724
@chloe-yeo
change import header
469aea8
@chloe-yeo
moving files to open source
23d9f29
@chloe-yeo
resolve build issues with ProgressReporter as API"
db15363
@chloe-yeo
apply naming changes
49c433a
@chloe-yeo
remove extra comma
4738c66
@chloe-yeo
only run interop tests if foundation framework
70f28ab
@chloe-yeo
rename file to subprogress
13cb72a
@chloe-yeo
add CMake files
07510ee
@chloe-yeo
CMake
3defc03
@chloe-yeo
Correct CMake
23f39f8
@chloe-yeo
exclude CMake from Package.swift
351b77a
@chloe-yeo
add trailing comma in Package.swift
12bed94
@chloe-yeo
formatting changes
97b15f7
@chloe-yeo
remove unused draft
41130b6
@chloe-yeo
add manual codable conformance
3e3ccb0
@chloe-yeo
new manual codable conformance for FileFormatStyle
f5e8522
@chloe-yeo
add default value static var to Property protocol
d840b1c
@chloe-yeo
code change for defaultValue
1afa651
@chloe-yeo
fix code
c4b94e4
@chloe-yeo
use SingleValueContainer to encode and decode FileFormatStyle
5d4ee8e
@chloe-yeo
update Codable implementation
2609895
@chloe-yeo
draft: reduce implementation keeping children values in array
8d1bad9
@chloe-yeo
draft: working version of reduce with children list, to be expanded t…
93c6741 
…o higher levels
@chloe-yeo
draft: reduce method with children list, recusive implementation done
f186548
@chloe-yeo
cleanup: replace vars with lets where needed
bf20bb4
@chloe-yeo
additional property dual node: version 3 implementation
55c1daf
@chloe-yeo
v3 fix to always preserve nil values in tree
1783e04
@chloe-yeo
deinit implementation for cancellation handling + getAllValues update…
28d5718 
… to use defaultValue when nil to keep consistency with subscript method
@chloe-yeo
change parent and portionInParent storage to be an array
d95a1a9
chloe-yeo added 27 commits June 16, 2025 16:07
@chloe-yeo
add dirty flag and update documentation
322a7df
@chloe-yeo
totalCount + completedCount updates swap to isDirty
c81e334
@chloe-yeo
debugging: using dirty bit for values update
834ead5
@chloe-yeo
temporary revert using dirty bit
803103a
@chloe-yeo
attempt at dirty flag - need to try again
a60bdfb
@chloe-yeo
remove format style from PR
e40c904
@chloe-yeo
remove source from Internationalization CMake
d5665bb
@chloe-yeo
revert to recursive implementation
a2540a7
@chloe-yeo
convert to use typed throws
a28d0b7
@chloe-yeo
remove setTotalCount method
e65e5d7
@chloe-yeo
rename manager to start
f11ba3e
@chloe-yeo
remove benchmark stuff
97b723f
@chloe-yeo
add code documentation
126e650
@chloe-yeo
make progress reporter properties public
ae2a201
@chloe-yeo
add values and total methods to ProgressReporter
507a8c5
@chloe-yeo
bug fix: fraction calculations for totalCount nil -> non-nil
83229a6
@chloe-yeo
debug fix: confition to updateChildFraction
3b8e9fd
@chloe-yeo
fix: values should return non-optional P.Value array
475a60c
@chloe-yeo
draft implementation of dirty bit
3f8ba5c
@chloe-yeo
drafting
f86e006
@chloe-yeo
move everything into one state
8d3ae93
@chloe-yeo
move locked variables up
3c1eef0
@chloe-yeo
dirty bit implementation - minimal working version
631381a
@chloe-yeo
fix implementation
2474c4e
@chloe-yeo
dirty bit implementation done
249e987
@chloe-yeo
clean up
c7cf9ae
@chloe-yeo
fix interop implementation to sync with dirty bit implementation
fadcda7
@chloe-yeo
Copy link
Contributor Author

chloe-yeo commented Jun 16, 2025

@swift-ci please test

@chloe-yeo
Copy link
Contributor Author

chloe-yeo commented Jul 31, 2025

Closing in favor of #1460

@chloe-yeo chloe-yeo closed this Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chloe-yeo