Skip to content

Remove unknown context from PredicateTests.Object type name #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Remove unknown context from PredicateTests.Object type name #1368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions Tests/FoundationEssentialsTests/PredicateTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,23 +22,27 @@ import Foundation
import RegexBuilder
#endif

// These types are non-private and in the global scope to ensure a consistent string type name for the debugDescription() test
struct PredicateTestObject {
var a: Int
var b: String
var c: Double
var d: Int
var e: Character
var f: Bool
var g: [Int]
var h: Date = .now
var i: Any = 3
}

struct PredicateTestObject2 {
var a: Bool
}

@Suite("Predicate")
private struct PredicateTests {
struct Object {
var a: Int
var b: String
var c: Double
var d: Int
var e: Character
var f: Bool
var g: [Int]
var h: Date = .now
var i: Any = 3
}

struct Object2 {
var a: Bool
}
typealias Object = PredicateTestObject
typealias Object2 = PredicateTestObject2

@Test func basic() throws {
let compareTo = 2
Expand Down Expand Up @@ -375,7 +379,7 @@ private struct PredicateTests {
let predicateName = _typeName(Predicate<Object>.self)
#expect(
debugDescription ==
"\(predicateName)(variable: (Variable(#)), expression: NilCoalesce(lhs: OptionalFlatMap(wrapped: ConditionalCast(input: KeyPath(root: Variable(#), keyPath: \\Object.i), desiredType: Swift.Int), variable: Variable(#), transform: Equal(lhs: Variable(#), rhs: Value<Swift.Int>(3))), rhs: Equal(lhs: KeyPath(root: Variable(#), keyPath: \\Object.h), rhs: Value<\(dateName)>(\(date.debugDescription)))))"
"\(predicateName)(variable: (Variable(#)), expression: NilCoalesce(lhs: OptionalFlatMap(wrapped: ConditionalCast(input: KeyPath(root: Variable(#), keyPath: \\PredicateTestObject.i), desiredType: Swift.Int), variable: Variable(#), transform: Equal(lhs: Variable(#), rhs: Value<Swift.Int>(3))), rhs: Equal(lhs: KeyPath(root: Variable(#), keyPath: \\PredicateTestObject.h), rhs: Value<\(dateName)>(\(date.debugDescription)))))"
)
}

Expand Down
Loading