Skip to content

Avoid passing (U)Int128 as test args #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Avoid passing (U)Int128 as test args #1376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28c7c9
Avoid passing (U)Int128 as test args
jmschonfeld Jun 24, 2025
ae737d0
Fix build issue
jmschonfeld Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 26 additions & 28 deletions Tests/FoundationEssentialsTests/JSONEncoderTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1393,21 +1393,20 @@ private struct JSONEncoderTests {
_testRoundTrip(of: testValue)
}

@Test(arguments: [
Int128.min,
Int128.min + 1,
-0x1_0000_0000_0000_0000,
0x0_8000_0000_0000_0000,
-1,
0,
0x7fff_ffff_ffff_ffff,
0x8000_0000_0000_0000,
0xffff_ffff_ffff_ffff,
0x1_0000_0000_0000_0000,
.max
])
func roundTrippingInt128(i128: Int128) {
_testRoundTrip(of: i128)
@Test func roundTrippingInt128() {
for i128 in [Int128.min,
Int128.min + 1,
-0x1_0000_0000_0000_0000,
0x0_8000_0000_0000_0000,
-1,
0,
0x7fff_ffff_ffff_ffff,
0x8000_0000_0000_0000,
0xffff_ffff_ffff_ffff,
0x1_0000_0000_0000_0000,
.max] {
_testRoundTrip(of: i128)
}
}

@Test func int128SlowPath() throws {
Expand All @@ -1434,19 +1433,18 @@ private struct JSONEncoderTests {
}
}

@Test(arguments: [
UInt128.zero,
1,
0x0000_0000_0000_0000_7fff_ffff_ffff_ffff,
0x0000_0000_0000_0000_8000_0000_0000_0000,
0x0000_0000_0000_0000_ffff_ffff_ffff_ffff,
0x0000_0000_0000_0001_0000_0000_0000_0000,
0x7fff_ffff_ffff_ffff_ffff_ffff_ffff_ffff,
0x8000_0000_0000_0000_0000_0000_0000_0000,
.max
])
func roundTrippingUInt128(u128: UInt128) {
_testRoundTrip(of: u128)
@Test func roundTrippingUInt128() {
for u128 in [UInt128.zero,
1,
0x0000_0000_0000_0000_7fff_ffff_ffff_ffff,
0x0000_0000_0000_0000_8000_0000_0000_0000,
0x0000_0000_0000_0000_ffff_ffff_ffff_ffff,
0x0000_0000_0000_0001_0000_0000_0000_0000,
0x7fff_ffff_ffff_ffff_ffff_ffff_ffff_ffff,
0x8000_0000_0000_0000_0000_0000_0000_0000,
.max] {
_testRoundTrip(of: u128)
}
}

@Test func uint128SlowPath() throws {
Expand Down
Loading