Cleanup swift-testing migration #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
jmschonfeld
commented
Jul 3, 2025
| test(.yearForWeekOfYear, date, expectedStart: nil, end: nil) | ||
| } | ||
|
|
||
| @Test func testDateInterval_DST() { |
Contributor
Author
There was a problem hiding this comment.
This test actually already existed in the GregorianCalendarInternationalizationTests suite, so it's just removed from here since it requires a non-GMT timezone
| @@ -0,0 +1,266 @@ | |||
| //===----------------------------------------------------------------------===// | |||
Contributor
Author
There was a problem hiding this comment.
This file was just moved from the old TestSupport folder, but the XCTest helpers in it were removed
parkera
approved these changes
Jul 3, 2025
…ftPM's build system
Contributor
Author
|
@swift-ci please test |
jrflat
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step in our swift-testing migration. Now that all tests use swift-testing we can:
XCTestandXCTest-based helper functionstypealiasdeclarations used to disambiguate betweenFoundationEssentialsandFoundationnow that the ambiguity is gone (due to the lack of an imported Foundation)TestSupportmodule to the tests folder and remove its dependencies onFoundationEssentials/FoundationInternationalizationto removeFoundationEssentialsTests's dependency onFoundationInternationalizationFoundationEssentialsthat depended onFoundationInternationalizationand add a new test to validate thatFoundationInternationalizationupcalls are not enabled inFoundationEssentialsTests