String.pathExtension should allow "..name" file names but not ".." #1410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Jul 8, 2025
jmschonfeld
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix for
String.pathExtensionfound when comparing the oldNSStringbehavior.String.pathExtensionreturns "" for path extensions appended to "." and ".." file names. This behavior is in part to prevent.deletingPathExtension()from returning a path referencing the current or parent directory.However,
String.pathExtensioncurrently returns "" for all file names that start with "..", so some valid file paths like "..name.txt" aren't receiving the correct behavior.This PR makes it so we only disallow extensions that would leave "." and ".." file names when removed. I also renamed a variable to make it more clear we're working with the
UTF8View.