Bin compat: use Platform.getFullExecutablePath instead of CommandLine.arguments.first for ProcessInfo.processName. #1411
+7
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….arguments.first for ProcessInfo.processName. The original NSProcessInfo implementation calls _CFProcessPath for processName, which Platform.getFullExecutablePath internally calls. We should maintain the same behavior for binary compatibility.
Contributor
Author
|
@swift-ci please test |
iCharlesHu
changed the title
jmschonfeld
approved these changes
Jul 9, 2025
…atch _CFProcessPath
Contributor
Author
|
@swift-ci please test |
kateinoigakukun
added a commit
to kateinoigakukun/swift-foundation
that referenced
this pull request
Jul 19, 2025
…out specific APIs. WASI does not provide a specific API to retrieve the process name, so we used `CommandLine.arguments.first` for `ProcessInfo.processName`. After swiftlang#1411, `CommandLine.arguments.first` started using platform-specific APIs to retrieve the process name, but the fallback path with `argv[0]` was removed. This commit restores that fallback for platforms like WASI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
NSProcessInfoimplementation calls_CFProcessPathforprocessName, whichPlatform.getFullExecutablePathinternally calls. We should maintain the same behavior for binary compatibility.