Resolve various warnings that were recently introduced#1744
Merged
jmschonfeld merged 1 commit intoswiftlang:mainfrom Feb 12, 2026
Merged
Resolve various warnings that were recently introduced#1744jmschonfeld merged 1 commit intoswiftlang:mainfrom
jmschonfeld merged 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Feb 12, 2026
Contributor
parkera
left a comment
There was a problem hiding this comment.
Always appreciate less warnings, thank you.
Contributor
Author
|
@swift-ci please test Windows platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While resolving a few specific warnings related to
Sendableannotations, I noticed a handful of warnings introduced that can easily be resolved and decided to fix them.Motivation:
Reduces the number of warnings when building foundation so that the set of produced warnings are more manageable and indicate true issues rather than spurious problems.
Modifications:
A variety of modifications to update the code based on the mentioned warnings
Result:
Resolves about 10-15 warnings overall
Testing:
Covered by existing unit test coverage