[WinSDK] Adjust the installer for platform modulemaps #458
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a companion to swiftlang/swift#83914.
egorzhdan
requested review from
shahmishal,
compnerd and
etcwilde
as code owners
compnerd
approved these changes
Aug 29, 2025
|
@compnerd I am attempting to test this installer, however, it doesn't seem to install swiftc.exe anywhere on my machine. I don't think this is likely to be caused by my change, I suspect it's broken on the mainline as well. |
|
That would be very interesting! I've been using the latest snapshot that was released on main for Windows and haven't seen any such issue. |
|
I just confirmed that nightly installers from swift.org also don't install swiftc.exe. Filed swiftlang/swift#84050. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to swiftlang/swift#83914.