Add Wasm Swift SDK checks for swift run
#166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
commented
Sep 17, 2025
MaxDesiatov
changed the title
swift run and swift testswift run
Enabling this check requires swiftlang/swift-package-manager#9114 to be merged first, which is currently failing due to an unfixed regression on `main`.
MaxDesiatov
commented
Sep 19, 2025
|
Verified as passing in https://ci.swift.org/job/swift-PR-Linux-smoke-test/22601/ |
MaxDesiatov
commented
Sep 19, 2025
MaxDesiatov
commented
Sep 19, 2025
MaxDesiatov
commented
Sep 19, 2025
Comment on lines
+50
to
+52
| RUN: find %{swiftpm_homedir}/ -mindepth 1 -maxdepth 1 | xargs rm -rf | ||
| RUN: %{swift-sdk} list | %{FileCheck} --check-prefix CHECK-SDK-LIST-FINAL %s | ||
| CHECK-SDK-LIST-FINAL: No Swift SDKs are currently installed. |
There was a problem hiding this comment.
It's a bit scary to remove the shared Swift SDK directory in a test tbh 😅 How about isolating SDK installation directory by --swift-sdks-path %t/swift-sdks or whatever?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.