javac plugin: keep parameter names #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding `-parameters` when we build java code using the java compiler plugin we retain parameter names and therefore we get: ``` func sayHello(_ x: Int32, _ y: Int32) -> Int32 ``` rather than ``` func sayHello(_ arg0: Int32, _ arg1: Int32) -> Int32 ``` which is a slightly nicer developer experience. When using with already built jars we can't influence that, but whenever using with java sources we actually build we should recommend keeping that flag probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding
-parameterswhen we build java code using the java compiler plugin we retain parameter names and therefore we get:rather than
which is a slightly nicer developer experience.
When using with already built jars we can't influence that, but whenever using with java sources we actually build we should recommend keeping that flag probably.