Minor cleanups to the JavaKit module and samples #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every other API uses the argument label "environment" for the JNI environment, so be consistent. Additionally, make it an optional parameter and query the running JVM to get the environment if we don't already have one.
ktoso
reviewed
Oct 25, 2024
| let jvm = try JavaVirtualMachine.shared(classPath: ["QuadraticSieve-1.0.jar"]) | ||
| do { | ||
| let sieveClass = try JavaClass<SieveOfEratosthenes>(in: jvm.environment()) | ||
| let sieveClass = try JavaClass<SieveOfEratosthenes>(environment: jvm.environment()) |
Collaborator
There was a problem hiding this comment.
+1, abusing the in: as label is always a tad too much in Swift libs 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform a few minor cleanups and expansions to the JavaKit module:
JavaClass.init(in:)toJavaClass.init(environment:)and make the parameter optional, to match other similar APIsjava.lang.Classbinding rather than hand-rolling itjava.lang.*class wrappers for primitive types (likeIntegerandDouble)