Java2Swift: Account for covariant overrides so we don't have duplicates #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we see methods with the same name and parameter types but different result types, check whether the result types are related and only keep the more specialized method.
DougGregor
commented
Oct 28, 2024
Comment on lines
-28
to
-30
| @JavaMethod | ||
| public func clone() throws -> JavaObject? | ||
|
|
Member
Author
There was a problem hiding this comment.
This method is subsumed by the covariant method above it, hence its removal.
Member
Author
|
It's a little hard to test the effect of this pull request in isolation, because we don't have a good way to test "does not emit this code", but I've marked where in the generated sources we drop a method because it's been subsumed by a covariant override. |
ktoso
approved these changes
Oct 28, 2024
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks good, nice to capture it in a "collector" 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we see methods with the same name and parameter types but different
result types, check whether the result types are related and only keep
the more specialized method.