JavaKit: map NULL jstring to the empty string #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Nov 7, 2024
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
lgtm, is it possible to write a test for this though?
Contributor
Author
|
Will look at tomorrow. |
There's an impedance mismatch here between the JNIType (which is optional) and the Swift type. Assuming this is intentional than init(fromJNI:in) should check for a NULL value and map it to the empty string. Fixes: swiftlang#155
Contributor
Author
|
added tests |
ktoso
approved these changes
Nov 7, 2024
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #155