Skip to content

Move layout constants from generated code to SwiftKit #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

Move layout constants from generated code to SwiftKit #233

merged 2 commits into from
May 26, 2025

Conversation

@madsodgaard
Copy link
Contributor

@madsodgaard madsodgaard commented May 26, 2025 •
edited
Loading

  • Moves the ValueLayout constants from the generated code to SwiftKit instead.
  • Also removes the unused C constants.
  • The generated code now correctly uses 32 or 64 bit int for Int type, based on platform.

Fixes #231

ktoso
ktoso approved these changes May 26, 2025
View reviewed changes
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup, lgtm :-)

@ktoso ktoso merged commit 00df828 into swiftlang:main May 26, 2025
12 checks passed
@madsodgaard madsodgaard deleted the move-layout-constants branch May 26, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktoso ktoso ktoso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove constant duplication in jextract generated code

2 participants

@madsodgaard @ktoso