[JExtract/JNI] Add support for variables #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Jul 12, 2025
ktoso
reviewed
Jul 12, 2025
ktoso
reviewed
Jul 12, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 12, 2025
SwiftKitCore/src/main/java/org/swift/swiftkit/core/ConfinedSwiftMemorySession.java
Show resolved
Hide resolved
ktoso
reviewed
Jul 12, 2025
ktoso
approved these changes
Jul 12, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Very nice, had some comments on this one. Please have a look
ktoso
reviewed
Jul 13, 2025
Samples/JExtractJNISampleApp/src/test/java/com/example/swift/MySwiftClassTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for both free and member variables. Also supports computed properties, throwing getters and getters/setters.
Boolean getters are now also generated as
isXboth for FFM and JNI to match Java conventions.