[JExtract/JNI] Add support for primitive non-escaping closures. #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Show resolved
Hide resolved
Collaborator
|
Overall looks good! I was looking at the last commit in here :) |
madsodgaard
force-pushed
the
jni-closures
branch
from
2012bd1 to
0e798f0
Compare
madsodgaard
changed the title
ktoso
reviewed
Jul 22, 2025
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
| let methodID$ = environment!.interface.GetMethodID(environment, class$, "apply", "(JZ)J")! | ||
| let arguments$: [jvalue] = [_0.getJValue(in: environment!), _1.getJValue(in: environment!)] | ||
| return Int64(fromJNI: environment!.interface.CallLongMethodA(environment, closure, methodID$, arguments$), in: environment!) | ||
| } |
Collaborator
There was a problem hiding this comment.
I'd kinda want to do one guard for the environment like we did elsewhere but this is minor, let's revisit holistically someday 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for importing non-escaping closures that only handle primitive types supported by
JavaKit.Just like FFM, each closure is imported as an
@FunctionalInterfacethat gets passed down to JNI. Then we call the apply method using JNI.