[JExtract/JNI] Support optionals in JNI mode #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Jul 31, 2025
Samples/JExtractJNISampleApp/src/test/java/com/example/swift/OptionalsTest.java
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 31, 2025
ktoso
reviewed
Aug 1, 2025
madsodgaard
changed the title
ktoso
approved these changes
Aug 1, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Very nice! Looks great, I skimmed the outputs earlier, looks all good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for optional return types and parameters in JNI mode of JExtract.
The overall idea for the conversion is that we use a "discriminator", which is a
byte :0or1` indicating whether the parameter or return value is present.For parameters we pass in the discriminator as an additional parameter.
Returning Integral types
Returning any type that can fit inside a bigger primitive integer type, we widen that type and store the discriminator at the end.
So for example, returning
Optional<Int8>, the underlying JNI would return ashort, which isbyte || byte. The above means that this method is used for(U)Int8, (U)Int16, (U)Int32.Other types
For any other types we do an indirect return to return the value of the discriminator.