[JExtract/JNI] Import enums #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Aug 4, 2025
ktoso
reviewed
Aug 4, 2025
Samples/JExtractJNISampleApp/src/test/java/com/example/swift/VehicleTest.java
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 4, 2025
Samples/JExtractJNISampleApp/src/test/java/com/example/swift/AlignmentTest.java
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 4, 2025
Samples/JExtractJNISampleApp/src/test/java/com/example/swift/VehicleTest.java
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 6, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 6, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 6, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 6, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Nice progress, going well :)
ktoso
reviewed
Aug 11, 2025
ktoso
reviewed
Aug 11, 2025
Samples/JExtractJNISampleApp/src/test/java/com/example/swift/VehicleEnumTest.java
Show resolved
Hide resolved
ktoso
reviewed
Aug 13, 2025
ktoso
reviewed
Aug 13, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looking very good so far! The caching needs rework but the rest is very nice work!
Sources/SwiftJavaDocumentation/Documentation.docc/SupportedFeatures.md
Outdated
Show resolved
Hide resolved
Sources/SwiftJavaDocumentation/Documentation.docc/SupportedFeatures.md
Outdated
Show resolved
Hide resolved
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Outdated
Show resolved
Hide resolved
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Outdated
Show resolved
Hide resolved
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Show resolved
Hide resolved
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Aug 14, 2025
| private func printNominalTypeThunks(_ printer: inout CodePrinter, _ type: ImportedNominalType) throws { | ||
| printHeader(&printer) | ||
|
|
||
| printJNICache(&printer, type) |
ktoso
reviewed
Aug 14, 2025
| return String(filePathPart.replacing(".swift", with: "+SwiftJava.swift")) | ||
| }) | ||
| self.expectedOutputSwiftFiles.insert("\(translator.swiftModuleName)Module+SwiftJava.swift") | ||
| self.expectedOutputSwiftFiles.insert("\(translator.swiftModuleName)+JNICaches.swift") |
Collaborator
|
Sorry about the conflict, you'll want to pick the |
madsodgaard
changed the title
Collaborator
|
Looking good! Really great work with the Enums overall! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for importing Swift enums, including failable initializers, associated values, variables and methods.