Update Package.swift #347
Merged
Update Package.swift #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve SPI JAVA_HOME check: don't suppress proper error messaging when the package manifest is used in the context of the SPI's build system. (This won't make a difference once Java is actually installed on our builders but gives a proper error message in the logs until that's the case.)
ktoso
approved these changes
Aug 4, 2025
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve SPI JAVA_HOME check: don't suppress proper error messaging when the package manifest is used in the context of the SPI's build system.
(This won't make a difference once Java is actually installed on our builders but gives a proper error message in the logs until that's the case.)