Properly extract usage of Data type from FoundationEssentials. #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Oct 20, 2025
Sources/JExtractSwiftLib/FFM/FFMSwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Oct 20, 2025
ktoso
reviewed
Oct 20, 2025
ktoso
reviewed
Oct 20, 2025
…ents to output swift file.
ktoso
approved these changes
Oct 22, 2025
ktoso
reviewed
Oct 22, 2025
|
Tests fixed |
|
Very nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that Swift2JavaTranslator does not detect the use of Data or DataProtocol when importing FoundationEssentials. I believe that on platforms other than Darwin, the use of such imports is common in order to reduce the size of the binary file due to ICU data, so I decided to fix this.