build: fix warning about kotlin not supporting jdk 25 #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it would fall back to 24, however also pollute logs with warnings about this: "Kotlin does not yet support 25 JDK target, falling back to Kotlin JVM_24 JVM target" so we can set this explicitly.
|
Meh, it's not quite right since CI uses 17... I wonder if we really have to do that with 17 at all, and we could just set lower language targets but keep using the latest JDK hmm... WDYT @madsodgaard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it would fall back to 24, however also pollute logs with warnings about this: "Kotlin does not yet support 25 JDK target, falling back to Kotlin JVM_24 JVM target" so we can set this explicitly.
I looked at https://kotlinlang.org/docs/gradle-configure-project.html#gradle-java-toolchains-support and I think this may be good enough...?