[JExtract/JNI] Add support for async Swift methods
#413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Oct 29, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftJavaConfigurationShared/JExtract/JExtractAsyncMode.swift
Outdated
Show resolved
Hide resolved
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
SwiftKitCore/src/main/java/org/swift/swiftkit/core/ConfinedSwiftMemorySession.java
Show resolved
Hide resolved
SwiftKitCore/src/main/java/org/swift/swiftkit/core/SwiftAsync.java
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Oct 29, 2025
Samples/SwiftJavaExtractJNISampleApp/src/jmh/java/com/example/swift/AsyncBenchmark.java
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Oct 30, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Show resolved
Hide resolved
ktoso
approved these changes
Oct 30, 2025
ktoso
approved these changes
Oct 31, 2025
0xZaph
reviewed
Oct 31, 2025
| if swiftFunctionResultType.isVoid { | ||
| printer.print("environment.interface.CallBooleanMethodA(environment, globalFuture, _JNIMethodIDCache.CompletableFuture.complete, [jvalue(l: nil)])") | ||
| } else { | ||
| printer.printBraceBlock("withVaList([SwiftJavaRuntimeSupport._JNIBoxedConversions.box(\(inner), in: environment)])") { printer in |
There was a problem hiding this comment.
On Android, I'm getting this compilation error:
withVaList([SwiftJavaRuntimeSupport._JNIBoxedConversions.box(resultBits$.getJNIValue(in: environment), in: environment)]) {
| `- error: cannot convert value of type 'jobject' (aka 'UnsafeMutableRawPointer') to expected element type 'any CVarArg'
This appears to originate from this code, though it compiles fine on Darwin. I'm not certain if this is an issue with my local Android sdk or not so just wanted to flag it.
There was a problem hiding this comment.
@0xZaph thanks for reporting this! seems like the issue is that the Android JNI imports jobjects as UnsafeRawMutablePointer, but that does not conform to CVarArg. And the "normal" JNI, imports it as OpaquePointer, which does.
I'll move away from withVaList, which also should fix swiftlang/swift-android-examples#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for extracting
asyncmethods from Swift.We use an upcall from Swift to Java to complete a
CompletableFutureAdditional changes:
SwiftKitSwifttoSwiftRuntimeFunctionsSwiftJavaRuntimeSupportfor runtime files needed by JExtract