Improve and document the JavaVirtualMachine initializer #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add options for the class path (so clients don't need to re-learn how to spell it) and for telling the JVM whether to ignore unrecognized arguments.
Based on our uses of the JNI APIs, the JavaKit path (Swift wrapping Java classes) only requires JNI as of Java 1.6, far earlier than the JDK 21 we had previously required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options for the class path (so clients don't need to re-learn how to
spell it) and for telling the JVM whether to ignore unrecognized arguments.
While here, reduce the JNI requirements down to JDK/JRE 1.6. We don't use any of the newer APIs. This addresses the functional part of #12