fix duplicated fields from superclass #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case of duplicated properties, e.g. from a base class it was
generating duplicate property definitions, e.g.:
```
extension JavaClass<PrivateKey> {
@JavaStaticField(isFinal: true)
public var serialVersionUID: Int64
@JavaStaticField(isFinal: true)
public var serialVersionUID: Int64
}
```
(see e.g. https://docs.oracle.com/javase/8/docs/api/java/security/PrivateKey.html)
which then fails the swift build.
Analog to methods, this now skips the property in case it wasn't directly from
the class itself.
ktoso
approved these changes
Dec 21, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
Collaborator
|
Tested locally while we debug the macOS CI problem -- lgtm, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case of duplicated properties, e.g. from a base class it was generating duplicate property definitions, e.g.:
(see e.g. https://docs.oracle.com/javase/8/docs/api/java/security/PrivateKey.html)
which then fails the swift build.
Analog to methods, this now skips the property in case it wasn't directly from the class itself.