Skip to content

Conversation

@AbdAlRahmanGad
Copy link
Contributor

  • fix install_untested_nightly_swift.sh name in Dockerfile
  • add curl to the Dockerfile
  • fix java and JAVA_HOME path

closes #59

- fix `install_untested_nightly_swift.sh` name in Dockerfile
- add `curl` to the Dockerfile
- fix `java` and `JAVA_HOME` path

Signed-off-by: AbdAlRahman Gad <[email protected]>
@AbdAlRahmanGad
Copy link
Contributor Author

Hi @ktoso,
Could you please review this patch when your time permits?

Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup thank you!

@AbdAlRahmanGad
Copy link
Contributor Author

You're welcome! Glad I could help.

@ktoso ktoso merged commit 8335fd8 into swiftlang:main Oct 10, 2024
9 checks passed
@AbdAlRahmanGad AbdAlRahmanGad deleted the docker branch October 22, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile has some issues

2 participants