Regenerate JavaKit Swift sources now that we have support for static fields #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jrosen081 FYI, this is the result of re-running the JavaKit generation now that your static field support has landed. |
jrosen081
approved these changes
Oct 11, 2024
Contributor
jrosen081
left a comment
jrosen081
left a comment
There was a problem hiding this comment.
This is awesome! Is the plan to always commit these every time we add more support or in the future have the first step to using this be run the make (or Gradle when the Makefile gets removed)?
Member
Author
We should commit these every time we add more support, since we need them there to build the Java2Swift tool itself. It's also a nice validation step. |
DougGregor
force-pushed
the
javakit-regenerate
branch
from
01d003b to
2066867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.