Rework Java2Swift to operate entirely on Java2Swift.config files #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration file should be explicit. If we want to infer Swift type names, we should do it when generating the configuration file.
Instead of having Java2Swift take in a list of classes on the command line, which the plugin synthesizes by reading a configuration file, and then emitting another almost-identical manifest file... rework the command-line interface to Java2Swift to operate entirely on the per-target Java2Swift.config files. This makes the plugin simpler, because it never has to look at build products for its dependencies. Change the `--jar-file` mode of Java2Swift to emit the configuration file but not translate any classes. This should be used as a tool, not a build step. Update the user guide to introduce JavaKit through the build tool.
Member
Author
|
This completes issue #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having Java2Swift take in a list of classes on the command line, which the plugin synthesizes by reading a configuration file, and then emitting another almost-identical manifest file... rework the command-line interface to Java2Swift to operate entirely on the per-target Java2Swift.config files. This makes the plugin simpler, because it never has to look at build products for its dependencies.
Change the
--jar-filemode of Java2Swift to emit the configuration file but not translate any classes. This should be used as a tool, not a build step.Update the user guide to introduce JavaKit through the build tool.