Java2Swift improvements for producing configuration files from Jar files #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the `classPath` field from each config file and feed the concatenated class path into the Java virtual machine instance we create. As part of this, clean up the code path that emits a configuration file with all of the classes within a Jar file.
The `ignoreUnrecognized` parameter to `JavaVirtualMachine.shared()` tells the JVM not to complain about options it doesn't recognize, which tends to mask usage errors. Change the default from `true` to `false`.
…ft.config We aren't ready to handle nested classes just yet.
ktoso
reviewed
Oct 18, 2024
| var classPathPieces: [String] = classpath | ||
| switch generationMode { | ||
| case .configuration(jarFile: let jarFile): | ||
| // * Jar file (in `-jar-file` mode) |
Collaborator
There was a problem hiding this comment.
I didn't notice this before, -jar probably would spell nicer for the option btw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the experience of producing
Java2Swift.configfiles from Jar files and better cope with layers of Swift-wrapped Java libraries. This includes:Java2Swift.configfiles with the one being used and providing those to the JVM instancefunc init()for a Java method namedinit