-
Notifications
You must be signed in to change notification settings - Fork 67
JavaKitCollection module #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ktoso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah a module for collections per se probably makes sense. Even if it doesn't follow the "module = package" separation (that'd be Util then hm).
|
Gotta add all the generated sources to .licenseignore, like we do: maybe it works with ** actually? |
We should generalize this to all of the various Java collection types.
It works, thanks! |
Yeah, I'm not sure this kind of splitting actually makes sense vs. just throwing everything into |
|
Yeah, we can clean this up later. There’s a bunch of “common types” that one is bound to encounter that could be in the core maybe |
Introduce a new JavaKitCollection module that wraps up a bunch of the Java collection-related classes for use in Swift