Skip to content

Conversation

@DougGregor
Copy link
Member

Introduce a new JavaKitCollection module that wraps up a bunch of the Java collection-related classes for use in Swift

Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah a module for collections per se probably makes sense. Even if it doesn't follow the "module = package" separation (that'd be Util then hm).

@ktoso
Copy link
Collaborator

ktoso commented Oct 18, 2024

Gotta add all the generated sources to .licenseignore, like we do:

Sources/JavaKit/generated/*
Sources/JavaKitJar/generated/*
Sources/JavaKitNetwork/generated/*
Sources/JavaKitReflection/generated/*
...

maybe it works with ** actually?

@DougGregor
Copy link
Member Author

maybe it works with ** actually?

It works, thanks!

@DougGregor
Copy link
Member Author

Hmm, yeah a module for collections per se probably makes sense. Even if it doesn't follow the "module = package" separation (that'd be Util then hm).

Yeah, I'm not sure this kind of splitting actually makes sense vs. just throwing everything into JavaKit and being done with it. There are lots more common classes that I keep encountering.

@DougGregor DougGregor merged commit a874bca into swiftlang:main Oct 18, 2024
11 checks passed
@DougGregor DougGregor deleted the javakitcollection branch October 18, 2024 04:41
@ktoso
Copy link
Collaborator

ktoso commented Oct 18, 2024

Yeah, we can clean this up later. There’s a bunch of “common types” that one is bound to encounter that could be in the core maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants