Refactor: Modernize platform-specific configurations in Package.swift #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyedaAnshrahGillani
requested review from
dmbryson,
jakepetroules and
owenv
as code owners
owenv
requested changes
Jul 10, 2025
| #else | ||
| return [.linkedLibrary("ncurses", .when(platforms: [.linux, .macOS]))] | ||
| #endif | ||
| return [.linkedLibrary("ncurses", .when(platforms: [.linux, .macOS, .freeBSD, .openBSD]))] |
There was a problem hiding this comment.
The FreeBSD platform condition isn't supported in tools-version:5.3, so this needs to continue using preprocessor conditionals as a workaround
There was a problem hiding this comment.
More specifically, "custom" isn't supported until 5.6 either.
| @@ -277,47 +273,6 @@ if !isStaticBuild { | |||
| ] | |||
| } | |||
|
|
|||
| if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil { | |||
There was a problem hiding this comment.
Why is this section deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
Package.swiftfile to modernize platform-specific configuration handling and improve code clarity.What’s Changed
#if os(...)preprocessor directives with the modern.when(platforms: [...])syntax.ncurses,sqlite3, etc.) into a unified, cleaner format.Why It Matters
.when(platforms: [...])approach is more declarative and concise, reducing clutter from scattered#ifblocks.Note
This is a non-functional update. It does not change runtime behavior but significantly improves the internal structure and maintainability of the build configuration.