feat(Homepage): darkmode support and global changes #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrambo
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
federicobucchi,
kaishin,
shahmishal and
timsneath
as code owners
|
|
||
| // Explicit syntax highlighting for C++ code blocks: | ||
|
|
||
| .language-cpp .cp, |
jesseaborden
approved these changes
May 30, 2025
Contributor
jesseaborden
left a comment
jesseaborden
left a comment
There was a problem hiding this comment.
Looking good. Thank you for knocking out all the dark mode code highlighting. Going to pull that into #1002 once this is merged 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We add support for homepage dark mode and some additional global updates.
Modifications:
Result:
This does a lot of heavy lifting around dark mode for homepage and navigation.
There are small issues that we will want to fix.