Add focus outline on code block tab button back for better accessibility #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandersandberg
requested review from
0xTim,
davelester,
daveverwer,
dempseyatgithub,
federicobucchi,
kaishin,
shahmishal and
timsneath
as code owners
kaishin
approved these changes
Jun 6, 2025
alexandersandberg
deleted the
alexandersandberg/add-focus-outline-to-code-block-tabs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring the focus outline on the code block tabs to make it easier to navigate the website using the keyboard.
Motivation:
It's good UX and useful for accessibility reasons to show where you are on the website when navigate using the tab key. Focus outlines should not be removed.
I simply added it back by removing
outline: none.We can consider a custom outline implementation if we want, but let's at least add back the default one in the meantime.
Modifications:
Result: