[cxx-interop] Add documentation about inferring SWIFT_SHARED_REFERENCE in c++ inheritance #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E in c++ inheritance
fahadnayyar
requested review from
davelester,
shahmishal,
timsneath and
tkremenek
as code owners
Xazax-hun
reviewed
Jun 11, 2025
Contributor
|
cc @egorzhdan |
egorzhdan
reviewed
Jun 13, 2025
fahadnayyar
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
federicobucchi and
kaishin
as code owners
Contributor
Author
|
CC: @j-hui |
fahadnayyar
commented
Jul 1, 2025
Contributor
Author
|
CC: @ravikandhadai |
j-hui
reviewed
Jul 2, 2025
Contributor
Author
|
This patch needs 2 important things to be included:
|
fahadnayyar
commented
Jul 4, 2025
|
|
||
| When a C++ type inherits from a `SWIFT_SHARED_REFERENCE` base type, the Swift compiler automatically infers `SWIFT_SHARED_REFERENCE` annotation for the derived type. | ||
| The derived type also gets imported as a reference type, and uses the same `retain` and `release` functions as its base class. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@j-hui I changed some text based on your suggestions but added my flavor as well. How does it look now?
fahadnayyar
commented
Jul 7, 2025
| // `object` will be released here. | ||
| ``` | ||
|
|
||
| ### Inference of Shared Reference behaviour in Derived Types |
Contributor
Author
There was a problem hiding this comment.
TODO: ### -> ####
Contributor
Author
|
including this in PR-1106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a sentence in the documentation thatthe foreign-reference annotations are now propagated to inherited C++ types