[cxx-interop] Document some caveats of safe interop #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
davelester,
shahmishal,
timsneath and
tkremenek
as code owners
Contributor
Author
j-hui
approved these changes
Jul 3, 2025
Contributor
j-hui
left a comment
j-hui
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple of small suggestions
Some of these like the compiler flag to enable the safe wrappers is not documented anywhere. Having this documentation in place can help more people to play around with the feature and report bugs.
Xazax-hun
force-pushed
the
gaborh/safety-caveats
branch
from
fbe7bca to
469c9cf
Compare
Xazax-hun
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
federicobucchi and
kaishin
as code owners
heckj
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these like the compiler flag to enable the safe wrappers is not documented anywhere. Having this documentation in place can help more people to play around with the feature and report bugs.