[cxx-interop] Document features that shipped in 6.1 and earlier #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
federicobucchi,
kaishin,
shahmishal and
timsneath
as code owners
Contributor
Author
j-hui
approved these changes
Apr 4, 2025
Contributor
j-hui
left a comment
j-hui
left a comment
There was a problem hiding this comment.
LGTM, save for a few editorial nits.
documentation/cxx-interop/index.md
Outdated
|
|
||
| ### Inheritance and Virtual Member Functions | ||
|
|
||
| Similarly to value types, casting an instance of a derived reference type to a |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| Similarly to value types, casting an instance of a derived reference type to a | |
| Similar to value types, casting an instance of a derived reference type to a |
|
|
||
| Other standard library types, like `std::unique_ptr`, `std::function` and | ||
| `std::variant` are not yet supported in Swift. | ||
| Other standard library types, like `std::function` and `std::variant` are not |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| Other standard library types, like `std::function` and `std::variant` are not | |
| Other standard library types like `std::function` and `std::variant` are not |
Contributor
There was a problem hiding this comment.
Either that, or:
Suggested change
| Other standard library types, like `std::function` and `std::variant` are not | |
| Other standard library types, like `std::function` and `std::variant`, are not |
But I don't think the commas are necessary
|
|
||
| Swift has some known limitations related to C++ interoperability support. | ||
| They're currently [listed on GitHub](https://github.com/swiftlang/swift/issues/66159). | ||
| They're currently [listed on GitHub](https://github.com/swiftlang/swift/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22c%2B%2B%20interop%22). |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| They're currently [listed on GitHub](https://github.com/swiftlang/swift/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22c%2B%2B%20interop%22). | |
| They are currently [tracked on GitHub](https://github.com/swiftlang/swift/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22c%2B%2B%20interop%22). |
Contributor
Author
There was a problem hiding this comment.
Agreed, that looks better
Contributor
Author
|
@swiftlang/website-workgroup folks, could you please approve this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.