Unskip swiftbuild tests that previously failed due to missing dsymutil #8879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter dynamic targets when discovering configured targets Use the build plan and binary path for the native build system tool path calculation
Add runtime library environment to the command plugin invocation for the tools that it runs
Fix failing package command test
Skip testCommandPluginTargetBuilds on Linux due to bug building fixture in release mode Skip testCommandPluginSymbolGraphCallbacks until symbol graph callback is supported with swiftbuild
…scope Skip test on autolink extract errors on non-macOS platforms
Fix todo comment spelling
…ager into command_plugins_swift_build
…ager into command_plugins_swift_build
cmcgee1024
requested review from
bkhouri,
bripeticca,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
Member
Author
|
@swift-ci please test |
bkhouri
approved these changes
Jun 27, 2025
Contributor
bkhouri
left a comment
bkhouri
left a comment
There was a problem hiding this comment.
Thought: consider converting this suite to Swift Testing
owenv
approved these changes
Jun 27, 2025
Contributor
owenv
left a comment
owenv
left a comment
There was a problem hiding this comment.
LGTM but the PR commit history seems a little off, might need a rebase?
marcprux
pushed a commit
to swift-everywhere/swift-package-manager
that referenced
this pull request
Jul 7, 2025
swiftlang#8879) Until[swift-build#607](swiftlang/swift-build#607) was merged, there was an error due to a missing dsymutil tool on non-macOS system, such as Linux. Remove the skip from the tests now that this is working. Fixes swiftlang#8862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until swift-build#607 was merged, there was an error due to a missing
dsymutil tool on non-macOS systems, such as Linux. Remove the skip
from the tests now that this is working.
Fixes #8862