[6.2][Commands] Migrate: Avoid duplicate fix-its and manifest updates when… #8929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
AnthonyLatsis,
bkhouri,
bnbarham,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
… building target for both host and destination This is a limited cherry-pick of swiftlang#8888 For example if a target is a dependency of a plugin we build it for host and destination and produce the same fix-it twice and attempt to update manifest twice because uniquing is done on the ModuleBuildDescriptions. The changes do the following: - Coalesce all the diagnostic files for the same target regardless of host or destination build to make it possible for `SwiftFixIt` to filter duplicate fix-its; - Unique based on module identity to prevent duplicate setting insertion. Resolves: rdar://155569285
xedin
force-pushed
the
rdar-155569285-6.2
branch
from
fcdec32 to
b93bec7
Compare
|
@swift-ci please test |
bnbarham
approved these changes
Jul 11, 2025
jakepetroules
approved these changes
Jul 11, 2025
AnthonyLatsis
approved these changes
Jul 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… building target for both host and destination
Explanation:
This is a limited cherry-pick of Support swift package migrate with --build-system swiftbuild #8888
For example if a target is a dependency of a plugin we build it for host and destination and produce the same fix-it twice and attempt to update manifest twice because uniquing is done on the ModuleBuildDescriptions.
The changes do the following:
SwiftFixItto filter duplicate fix-its;Resolves: rdar://155569285
Main Branch PR: Support swift package migrate with --build-system swiftbuild #8888
Risk: Very Low. This is a narrow fix for
swift package migratecommand.Reviewed By: Me and @AnthonyLatsis reviewed the work in the main PR.
Testing: Added new test-cases to the suite.